Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when a language was not registered #5

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Fix errors when a language was not registered #5

merged 2 commits into from
Jun 27, 2017

Conversation

Angelmmiguel
Copy link
Contributor

Hello @bebraw,

I'm using your library with remark-react. I found an issue when I try to convert a markdown with a block of code that uses a non-registered language:

Uncaught Error: Unknown language: `css` is not registered
    at coreHighlight (http://localhost:3000/static/js/bundle.js:31629:11)
    at High.highlight (http://localhost:3000/static/js/bundle.js:31566:20)
    at Lowlight (http://localhost:3000/static/js/bundle.js:50982:11)
    at http://localhost:3000/static/js/bundle.js:41554:16

I believe that this is a pretty common use case because I don't know all the languages the user will use. Also, if the user doesn't specify the language, the block is rendered without trying to guess it. Now, the component always returns a Lowlight component so, highlight.js can try to guess the language.

What do you think?

@bebraw
Copy link
Collaborator

bebraw commented Jun 26, 2017

That seems smart.

I'm not using the package actively anymore anywhere. Would you like to take over it? I don't mind handling the transition and setting up the rights.

If that's too much, I can also merge and cut a release. 👍

@Angelmmiguel
Copy link
Contributor Author

Thanks for your fast response @bebraw!

I'm not using the package actively anymore anywhere.

Did you find an alternative to it or just finished the project that required this lib?

Would you like to take over it? I don't mind handling the transition and setting up the rights.

The library is pretty simple so I believe that I don't need any other change :). For me, it's enough if you can merge and publish a new version.

In the future, if I need to add more changes and improvements to it, I don't mind to take over it and continue your work.

Thanks!

@bebraw bebraw merged commit af9b710 into inlinestyle:master Jun 27, 2017
@bebraw
Copy link
Collaborator

bebraw commented Jun 27, 2017

Did you find an alternative to it or just finished the project that required this lib?

I ended up using entirely different solution (Catalog) that eliminated the whole problem for me (no remark in the project anymore).

The library is pretty simple so I believe that I don't need any other change :). For me, it's enough if you can merge and publish a new version.

In the future, if I need to add more changes and improvements to it, I don't mind to take over it and continue your work.

Ok, cool. Thanks.

@Angelmmiguel
Copy link
Contributor Author

Thank you for your comments and the release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants