Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cmd): Update doc for secret key option in create cmd #132

Merged

Conversation

Quentinchampenois
Copy link
Contributor

Description

Hello! this is a very light PR as I am just discovering this project.

I noticed a typo in the secret-key description for the create command, this PR just update this description.

Thank you for this nice project !

How Has This Been Tested?

Confirmed the new description by running go run . help create

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Note

Also the link in PR Template is no longer available : CONTRIBUTION guide

Copy link

derek bot commented Oct 9, 2024

Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide.

### :bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@Quentinchampenois Quentinchampenois force-pushed the refactor/description_create_cmd branch from 53cf44e to ffc693c Compare October 9, 2024 21:10
Signed-off-by: Quentin Champenois <quentin.champenois7@gmail.com>
@Quentinchampenois Quentinchampenois force-pushed the refactor/description_create_cmd branch from ffc693c to 21224ba Compare October 9, 2024 21:16
@derek derek bot removed the no-dco label Oct 9, 2024
@alexellis
Copy link
Member

Hi @Quentinchampenois

Thanks for the interest.

I was just curious why you sent this particular PR, I don't recognise you as an inlets subscriber?

Alex

@Quentinchampenois
Copy link
Contributor Author

Hello @alexellis ,

No I am not, I just discovered the project while reading your blog about k3s on raspberry pi, because I noticed the typo in help command I suggested the edit.

If you are open to contributions I might be interested to contribute in the future

@Quentinchampenois Quentinchampenois marked this pull request as ready for review October 9, 2024 22:18
@alexellis
Copy link
Member

The contribution is fine, and open to them.

I was just curious as I didn't understand the motivation. Thanks for explaining.

Arkade - https://github.com/alexellis/arkade has more opportunties to contribute, and perhaps https://github.com/openfaas/faas-cli

If you use or have used Kubernetes, check out k3sup and my newest project: kubetrim which might have the odd opportunity to contribute.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 213b026 into inlets:master Oct 9, 2024
@alexellis
Copy link
Member

This same change may apply in other commands if you want to look, i.e. delete?

@Quentinchampenois Quentinchampenois deleted the refactor/description_create_cmd branch October 9, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants