-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cmd): Update doc for secret key option in create cmd #132
refactor(cmd): Update doc for secret key option in create cmd #132
Conversation
Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide.
This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
53cf44e
to
ffc693c
Compare
Signed-off-by: Quentin Champenois <quentin.champenois7@gmail.com>
ffc693c
to
21224ba
Compare
Thanks for the interest. I was just curious why you sent this particular PR, I don't recognise you as an inlets subscriber? Alex |
Hello @alexellis , No I am not, I just discovered the project while reading your blog about k3s on raspberry pi, because I noticed the typo in help command I suggested the edit. If you are open to contributions I might be interested to contribute in the future |
The contribution is fine, and open to them. I was just curious as I didn't understand the motivation. Thanks for explaining. Arkade - https://github.com/alexellis/arkade has more opportunties to contribute, and perhaps https://github.com/openfaas/faas-cli If you use or have used Kubernetes, check out k3sup and my newest project: kubetrim which might have the odd opportunity to contribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This same change may apply in other commands if you want to look, i.e. delete? |
Description
Hello! this is a very light PR as I am just discovering this project.
I noticed a typo in the
secret-key
description for thecreate
command, this PR just update this description.Thank you for this nice project !
How Has This Been Tested?
Confirmed the new description by running
go run . help create
Checklist:
I have:
git commit -s
Note
Also the link in PR Template is no longer available : CONTRIBUTION guide