Implements SLKeyboard protocol for custom keyboards #105
Conversation
|
This is neat @j-mutter! Thanks and sorry for the delay in reviewing--I'm slowly getting back into Subliminal after a hefty release of Inkling right before the holidays. I just fixed some things in the build process--would you mind rebasing on top of |
| To tap individual keys on the keyboard, use SLKeyboardKey. | ||
| */ | ||
| @interface SLKeyboard : SLStaticElement | ||
| @protocol SLKeyboard <NSObject> |
There was a problem hiding this comment.
This is an elegant way to support different keyboards. Before your request I hadn't heard of UIInputView--would you mind describing it/the rationale here in documentation for the SLKeyboard protocol?
|
@wearhere Done and done :) Sorry for the delay |
|
Looks like everything passed except for some documentation errors--missing parameters on the new methods added to |
|
Travis is 💚 now :) |
|
👍 Thanks again! |
Implements SLKeyboard protocol for custom keyboards
With iOS 7 SDK, UIKit now exposes UIInputView to allow custom inputs/keyboards to be created.
This PR provides an
SLKeyboardprotocol for such views, refactors the originalSLKeyboardclass to implement the protocol methods, and updatesSLTextFieldandSLTextViewto use different keyboards as needed.