Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webpack #87

Merged
merged 1 commit into from
Oct 21, 2024
Merged

remove webpack #87

merged 1 commit into from
Oct 21, 2024

Conversation

SeUkKim
Copy link
Contributor

@SeUkKim SeUkKim commented Oct 18, 2024

Since we are using vite, remove unused webpack.

Summary by CodeRabbit

  • Chores
    • Updated project version to 0.2.19.
    • Removed unused development dependencies to streamline the project.
    • Deleted the Webpack configuration file, transitioning to a different build process.

These changes enhance project maintainability and prepare for future development.

Copy link

coderabbitai bot commented Oct 18, 2024

Walkthrough

The pull request involves significant modifications to the package.json and the removal of the webpack.config.js file. The version in package.json has been updated to 0.2.19, and several Webpack-related packages have been removed from devDependencies. The webpack.config.js file, which contained configurations for both web and Node.js builds, has been deleted, indicating a shift away from Webpack in the project.

Changes

File Change Summary
package.json Updated version to 0.2.19. Removed tsconfig-paths-webpack-plugin, webpack, webpack-bundle-analyzer, and webpack-cli from devDependencies. No changes to dependencies or other fields.
webpack.config.js Deleted the file, which contained configurations for Webpack builds for web and Node.js environments.

Possibly related PRs

  • cleanse deps #73: Involves the removal of several packages from the devDependencies section of package.json, aligning with the main PR's focus on removing dependencies related to Webpack.
  • Build with Vite #79: Reflects a significant update in the package.json file, transitioning from Webpack to Vite, relevant to the main PR's removal of Webpack-related dependencies and the deletion of the webpack.config.js file.

Suggested reviewers

  • Vritra4

🐰 In the meadow, hops a little hare,
With changes afoot, it dances with flair.
Webpack's been dropped, like leaves in the breeze,
Vite takes the stage, with grace and with ease.
A new version's here, let the coding commence,
In the world of JavaScript, we leap with suspense! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8552349 and 99c7658.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • webpack.config.js (0 hunks)
💤 Files with no reviewable changes (1)
  • webpack.config.js
🧰 Additional context used
🔇 Additional comments (4)
package.json (4)

Line range hint 3-3: Version update looks good.

The version has been incremented to "0.2.19", which is consistent with the changes made in this PR. This follows semantic versioning practices.


60-60: Webpack dependencies removed as intended.

The removal of webpack-related dependencies (tsconfig-paths-webpack-plugin, webpack, webpack-bundle-analyzer, webpack-cli) aligns with the PR objective of removing unused webpack configuration. Keeping vite-plugin-dts is consistent with the project's transition to using Vite.


Line range hint 1-92: Changes are consistent with PR objectives.

The modifications to package.json, particularly the removal of webpack-related dependencies, are in line with the PR objective of eliminating unused webpack configuration. The retention of Vite-related dependencies (e.g., vite-plugin-dts) supports the stated transition to using Vite for the build process.


60-60: Verify complete removal of webpack-related dependencies.

Please ensure that all webpack-related dependencies and configurations have been removed from the project. It might be helpful to search for any remaining references to webpack in other configuration files or scripts.

Run the following script to check for any remaining webpack-related dependencies or configurations:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

package-lock.json
  • @discoveryjs/json-ext@0.5.7
  • @polka/url@1.0.0-next.21
  • @webpack-cli/configtest@1.2.0
  • @webpack-cli/info@1.5.0
  • @webpack-cli/serve@1.7.0
  • clone-deep@4.0.1
  • commander@7.2.0
  • duplexer@0.1.2
  • envinfo@7.8.1
  • fastest-levenshtein@1.0.16
  • gzip-size@6.0.0
  • interpret@2.2.0
  • is-plain-object@2.0.4
  • isobject@3.0.1
  • kind-of@6.0.3
  • mrmime@1.0.1
  • opener@1.5.2
  • rechoir@0.7.1
  • shallow-clone@3.0.1
  • sirv@1.0.19
  • totalist@1.1.0
  • tsconfig-paths@4.1.0
  • tsconfig-paths-webpack-plugin@4.0.0
  • webpack-bundle-analyzer@4.7.0
  • webpack-cli@4.10.0
  • webpack-merge@5.8.0
  • wildcard@2.0.0
package.json
  • tsconfig-paths-webpack-plugin@^4.0.0
  • webpack@^5.94.0
  • webpack-bundle-analyzer@^4.6.1
  • webpack-cli@^4.10.0

@SeUkKim SeUkKim requested a review from joon9823 October 21, 2024 07:12
Copy link
Collaborator

@joon9823 joon9823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joon9823 joon9823 merged commit e8f6f41 into main Oct 21, 2024
4 checks passed
@joon9823 joon9823 deleted the feat/remove-webpack branch October 21, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants