-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyfill #84
Closed
Polyfill #84
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6c65e06
add polyfill
Vritra4 89f14a1
Merge remote-tracking branch 'origin' into polyfill
Vritra4 ccd49ee
Merge remote-tracking branch 'origin' into polyfill
Vritra4 d0c142d
Merge branch 'main' of https://github.com/initia-labs/initia.js into …
joon9823 7742c2f
Apply lint and remove semicolon
joon9823 a0de751
Change to Number.parseInt for sense of unity
joon9823 830fc3d
Merge branch 'main' of https://github.com/initia-labs/initia.js into …
joon9823 cd4b5ee
Replace Buffer with Uint8Array
joon9823 ee54c82
Remove webpack
joon9823 4733e0a
Remove Buffer from mnemonic key
joon9823 f593173
Remove ledger key and unused packages
joon9823 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change to Number.parseInt for sense of unity
- Loading branch information
commit a0de75119788abc1aeeb86bc81725bc6b7be7e55
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider adding error handling for parsing operations.
While the current implementation works well for valid input, it might be beneficial to add error handling for cases where the parsed strings are not valid numbers. This would make the code more robust and prevent potential runtime errors.
Here's a suggested implementation with error handling:
This implementation adds checks for
NaN
values after parsing and throws an error if invalid data is encountered.