feat: culinaris #245
feat: culinaris #245
Conversation
WalkthroughThis pull request introduces configuration files for the "culinaris" testnet, including a new Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
testnets/culinaris/images/logo.pngis excluded by!**/*.png
📒 Files selected for processing (3)
testnets/culinaris/assetlist.json(1 hunks)testnets/culinaris/chain.json(1 hunks)testnets/initia/chain.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- testnets/culinaris/assetlist.json
🧰 Additional context used
🪛 GitHub Actions: PR workflow
testnets/initia/chain.json
[error] Schema validation error: '1' is not of type 'integer'. The value should be an integer instead of a string.
testnets/culinaris/chain.json
[error] Schema validation error: '1' is not of type 'integer'. The value should be an integer instead of a string.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages: registry-initiation-1
🔇 Additional comments (4)
testnets/culinaris/chain.json (3)
4-5: Verify EVM chain ID uniquenessThe EVM chain ID (2906125577721809) should be unique across all chains to prevent replay attacks.
✅ Verification successful
EVM chain ID is unique
The EVM chain ID 2906125577721809 is unique across all chain configurations. No conflicts found with other chains.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for duplicate EVM chain IDs rg -g '*.json' '"evm_chain_id":\s*2906125577721809' --type jsonLength of output: 131
Script:
#!/bin/bash # Search for any EVM chain IDs in different formats echo "=== Searching for all EVM chain IDs ===" rg -g '*.json' '"evm_chain_id":\s*[0-9x]+' --type json -A 1 echo -e "\n=== Searching for potential hex format ===" rg -g '*.json' '"evm_chain_id":\s*"?0x' --type json echo -e "\n=== Searching for scientific notation ===" rg -g '*.json' '"evm_chain_id":\s*[0-9]+e[0-9]+' --type jsonLength of output: 849
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] Schema validation error: '1' is not of type 'integer'. The value should be an integer instead of a string.
74-86: Verify IBC channel configuration consistencyThe IBC channel configuration needs to be consistent with the connected chain (initiation-2).
✅ Verification successful
IBC channel configuration is consistent ✅
The channel configuration in culinaris matches the network-wide standard pattern used across multiple chains connected to initiation-2, with channel-0 for token transfers (ics20-1) and channel-1 for NFT transfers (ics721-1).
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the channel IDs match on both chains rg -g 'chain.json' '"channel-0".+"transfer".+"initiation-2"' --type json rg -g 'chain.json' '"channel-1".+"nft-transfer".+"initiation-2"' --type jsonLength of output: 149
Script:
#!/bin/bash # Find all chain.json files echo "=== Finding all chain.json files ===" fd chain.json # Search for initiation-2 chain ID in any JSON file echo -e "\n=== Searching for initiation-2 chain ID ===" rg -g '*.json' '"chain_id".*"initiation-2"' -C 5Length of output: 9735
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] Schema validation error: '1' is not of type 'integer'. The value should be an integer instead of a string.
35-61: Verify API endpoints accessibility and securityThe API endpoints use a consistent domain pattern but need verification:
- All endpoints should be accessible
- SSL certificates should be valid
- Rate limiting should be in place
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] Schema validation error: '1' is not of type 'integer'. The value should be an integer instead of a string.
testnets/initia/chain.json (1)
Line range hint
1-94: Fix schema validation errorThe pipeline reports: "'1' is not of type 'integer'". This indicates that a numeric field is being set as a string instead of an integer.
Please review all numeric fields and ensure they are not wrapped in quotes. Common fields to check: version numbers, chain IDs, and numeric configurations.
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] Schema validation error: '1' is not of type 'integer'. The value should be an integer instead of a string.
Deploying registry-initiation-1 with
|
| Latest commit: |
7206434
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73d1a7bc.registry-initiation-1.pages.dev |
| Branch Preview URL: | https://feat-culinaris.registry-initiation-1.pages.dev |
Deploying registry-devnet with
|
| Latest commit: |
7206434
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea11bfbb.registry-devnet.pages.dev |
| Branch Preview URL: | https://feat-culinaris.registry-devnet.pages.dev |
Deploying registry-testnet with
|
| Latest commit: |
7206434
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bedf9e9f.initia-registry-testnets.pages.dev |
| Branch Preview URL: | https://feat-culinaris.initia-registry-testnets.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
testnets/culinaris/images/INIT.pngis excluded by!**/*.png
📒 Files selected for processing (1)
testnets/culinaris/assetlist.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages: registry-initiation-1
🔇 Additional comments (6)
testnets/culinaris/assetlist.json (6)
1-46: Overall structure looks goodThe asset configuration follows proper JSON structure and includes all essential fields for the culinaris testnet token.
33-33: Empty CoinGecko ID is appropriateThe empty CoinGecko ID is correct for a testnet token.
9-11: Verify denomination security implicationsPlease ensure:
- The exponent configuration (0 and 6) aligns with the bridge contract expectations
- The base denomination hash is correctly derived and matches the bridge configuration
This is critical for preventing potential token conversion issues.
Also applies to: 13-15
7-16: Verify denomination hash format and consistencyThe base denomination uses a hash format that should be verified:
- Hash format:
l2/83db4af0de8965c851672915eaa857f0911385f7d71f9da1decb2504d3d3ffdd- Exponent mapping:
0for base,6for display (1 INIT = 1,000,000 base units)✅ Verification successful
Hash format is valid and consistent across networks
The denomination hash format follows the established pattern used across all network configurations, with each network maintaining its unique l2-prefixed hash identifier.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other denomination configurations to verify consistency rg -g '*.json' '"denom":\s*"l2/[a-f0-9]{64}"' --type jsonLength of output: 1269
2-3: Verify schema file existence and validityThe referenced schema file needs to be verified to ensure proper asset configuration validation.
✅ Verification successful
Schema reference is valid and correctly configured
The schema file exists, is a valid JSON Schema, and the relative path "../../assetlist.schema.json" correctly points to it from the asset file location.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if schema file exists and is valid JSON if [ -f "assetlist.schema.json" ]; then jq '.' assetlist.schema.json > /dev/null 2>&1 if [ $? -eq 0 ]; then echo "Schema file exists and is valid JSON" else echo "Schema file exists but is not valid JSON" fi else echo "Schema file not found" fiLength of output: 164
Script:
#!/bin/bash # Check schema content and verify it's a JSON Schema echo "=== Schema Content ===" jq 'select(."$schema" | contains("json-schema.org"))' assetlist.schema.json echo -e "\n=== Verify Relative Path ===" # Get the actual path of the schema file relative to the asset file realpath --relative-to="$(dirname testnets/culinaris/assetlist.json)" assetlist.schema.jsonLength of output: 14951
19-30: Verify bridge configuration and token mappingThe trace configuration maps the token to the Initia mainnet:
- Bridge ID: "314"
- Source token: "uinit" on "initia" chain
✅ Verification successful
Bridge configuration verified and consistent
The bridge configuration in culinaris testnet is correctly set up with a unique bridge ID "314" and properly maps to the Initia native token (uinit). The configuration is consistent within its testnet environment.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other bridge configurations to verify consistency rg -g '*.json' '"bridge_id":\s*"314"' --type json -C 5Length of output: 685
Script:
#!/bin/bash # Search for other Initia chain configurations rg -g '*.json' '"chain_name":\s*"initia"' --type json -C 5Length of output: 16255
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/validate_chainjson.yml (1)
12-12: Consider documenting the reason for version pinningWhile pinning to version 1.4.1 helps prevent breaking changes, it may miss security updates. Consider:
- Adding a comment explaining why this specific version is required
- Setting up dependabot to track security updates for this dependency
testnets/culinaris/chain.json (1)
28-37: Consider adding binary checksumsFor security, consider adding SHA256/SHA512 checksums for the binary downloads to allow users to verify the integrity of downloaded files.
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] JSON schema validation failed: '1' is not of type 'integer'. The value should be an integer instead of a string.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
testnets/culinaris/images/INIT.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
.github/workflows/validate_chainjson.yml(1 hunks)testnets/culinaris/chain.json(1 hunks)
🧰 Additional context used
📓 Learnings (1)
testnets/culinaris/chain.json (1)
Learnt from: ALPAC-4
PR: initia-labs/initia-registry#245
File: testnets/culinaris/chain.json:14-19
Timestamp: 2025-01-13T16:25:04.252Z
Learning: The culinaris testnet chain is designed to operate without staking tokens and fee tokens, as indicated by empty arrays in the configuration.
🪛 GitHub Actions: PR workflow
testnets/culinaris/chain.json
[error] JSON schema validation failed: '1' is not of type 'integer'. The value should be an integer instead of a string.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages: registry-initiation-1
🔇 Additional comments (4)
testnets/culinaris/chain.json (4)
4-5: Verify chain ID format consistencyThe chain ID "culinaris-2" suggests this is the second version. Ensure this matches your versioning strategy and that any migration steps from culinaris-1 are documented if applicable.
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] JSON schema validation failed: '1' is not of type 'integer'. The value should be an integer instead of a string.
14-24: Confirm zero gas price configurationThe fee token configuration shows all gas prices set to 0. While this might be intentional for a testnet, it could potentially lead to spam attacks. Consider adding a minimal gas price for basic spam protection.
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] JSON schema validation failed: '1' is not of type 'integer'. The value should be an integer instead of a string.
43-69: Verify API endpoint accessibilityPlease verify that all API endpoints are:
- Accessible and responding correctly
- Using valid SSL certificates
- Properly configured for CORS if needed
✅ Verification successful
API endpoints are properly configured
All endpoints are accessible with valid SSL certificates. The response codes are as expected for each protocol:
- RPC endpoint responds with 200 OK
- REST endpoint's 501 is normal without a path
- JSON-RPC's 405 is expected (requires POST)
- WebSocket's 400 is correct (requires WebSocket protocol)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify API endpoints accessibility and SSL certificates for endpoint in \ "https://maze-rpc-s2-b53886e8-ebca-41a5-8dd7-64884b25fb2c.public-think-factory.newmetric.xyz" \ "https://maze-rest-s2-b53886e8-ebca-41a5-8dd7-64884b25fb2c.public-think-factory.newmetric.xyz" \ "https://maze-jsonrpc-s2-b53886e8-ebca-41a5-8dd7-64884b25fb2c.public-think-factory.newmetric.xyz" \ "https://maze-ws-s2-b53886e8-ebca-41a5-8dd7-64884b25fb2c.public-think-factory.newmetric.xyz" do echo "Checking $endpoint" curl -sSf -o /dev/null -w "HTTP Status: %{http_code}\nSSL Verify: %{ssl_verify_result}\n" "$endpoint" doneLength of output: 3454
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] JSON schema validation failed: '1' is not of type 'integer'. The value should be an integer instead of a string.
82-95: Verify IBC channel configurationsPlease verify:
- The channel IDs match the configuration on the initiation-2 chain
- The versions are compatible with the connected chain
✅ Verification successful
IBC channel configurations are correct
The channel configurations in culinaris chain are consistent with the network-wide pattern:
- channel-0 (transfer/ics20-1) for token transfers
- channel-1 (nft-transfer/ics721-1) for NFT transfers
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for corresponding channel configurations in initiation-2 chain rg -A 5 "channel-0|channel-1" | grep -B 2 -A 2 "initiation-2"Length of output: 4575
Script:
#!/bin/bash # Find and show initiation-2 chain configuration fd initiation-2 --type f | grep chain.json echo "---" fd initiation-2 --type f --exec cat {} | grep -A 20 "ibc_channels"Length of output: 128
Script:
#!/bin/bash # Search for initiation-2 chain configuration echo "=== Files containing initiation-2 ===" rg -l "initiation-2" testnets/ echo -e "\n=== Chain configuration patterns ===" rg -A 10 '"chain_id":\s*"initiation-2"' testnets/Length of output: 10171
🧰 Tools
🪛 GitHub Actions: PR workflow
[error] JSON schema validation failed: '1' is not of type 'integer'. The value should be an integer instead of a string.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
chain.schema.json (1)
533-543: Consider enhancing the conditional validation for EVM endpoints.When
minitia.typeis "minievm", bothjson-rpcandjson-rpc-websocketarrays are required. Consider moving theminContainsrequirements into the conditional validation to make it more explicit."then": { "required": ["evm_chain_id"], "properties": { "apis": { - "required": ["json-rpc", "json-rpc-websocket"] + "required": ["json-rpc", "json-rpc-websocket"], + "properties": { + "json-rpc": { + "minContains": 1 + }, + "json-rpc-websocket": { + "minContains": 1 + } + } } } },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
chain.schema.json(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages: registry-initiation-1
🔇 Additional comments (1)
chain.schema.json (1)
119-119: LGTM! Type corrections align with JSON Schema standards.The changes correctly update
minContainsfrom string to numeric values, which is the proper type as per JSON Schema specification.Also applies to: 495-495, 502-502, 533-533, 541-541
Add culinaris chain
Summary by CodeRabbit
New Features
Connectivity
Chores
Bug Fixes