chore: adds ing-input-amount-dropdown tests #2505
Conversation
|
| spy.restore(); | ||
| }); | ||
|
|
||
| it('can override "all-countries-label"', async () => { |
There was a problem hiding this comment.
| it('can override "all-countries-label"', async () => { | |
| it('can override "all-currencies-label"', async () => { |
| 'dropdown', | ||
| ); | ||
| // @ts-expect-error [allow-protected] | ||
| el._preferredCountriesLabel = 'foo'; |
There was a problem hiding this comment.
| el._preferredCountriesLabel = 'foo'; | |
| el._preferredCurrenciesLabel = 'foo'; |
| spy.restore(); | ||
| }); | ||
|
|
||
| it('can override "preferred-countries-label"', async () => { |
There was a problem hiding this comment.
| it('can override "preferred-countries-label"', async () => { | |
| it('can override "preferred-currencies-label"', async () => { |
| @@ -0,0 +1,269 @@ | |||
| const countryToCurrencyList = { | |||
There was a problem hiding this comment.
Can we add the source of this list?
| */ | ||
| export const countryToCurrencyMap = new Map(Object.entries(countryToCurrencyList)); | ||
|
|
||
| export const allCurrencies = new Set(Object.values(countryToCurrencyList)); |
There was a problem hiding this comment.
If we sort the list alphabetical based on allCurrencies, we can use type ahead to select an option.
| export const allCurrencies = new Set(Object.values(countryToCurrencyList)); | |
| export const allCurrencies = new Set(Object.values(countryToCurrencyList).sort()); |
| 'model-value-changed': this._onDropdownValueChange, | ||
| }, | ||
| labels: { | ||
| selectCountry: localizeManager.msg('lion-input-tel:selectCountry'), |
There was a problem hiding this comment.
This still points to the input tel :)
I will requests translations for these 2 sentences. This will take some time, for now we should be fine with only the english text.
| selectCountry: localizeManager.msg('lion-input-tel:selectCountry'), | |
| selectCurrency: localizeManager.msg('lion-input-amount-dropdown:selectCurrency'), |
| expect(getDropdownValue(/** @type {DropdownElement} */ (el.refs.dropdown.value))).to.equal( | ||
| 'EUR', | ||
| ); | ||
| }); |
There was a problem hiding this comment.
| }); | |
| }); | |
| it('updates the modelValue based on the currency ', async () => { | |
| // JPY has no decimals, while JOD has 3 decimals. | |
| }); |
| ); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
| }); | |
| }); | |
| describe('On locale change', () => { | |
| it('on "en-GB" it sets the dropdown as a prefix', async () => {}); | |
| it('on "nl-NL" it sets the dropdown as a suffix', async () => {}); | |
| }); |
| @@ -0,0 +1 @@ | |||
| export { LionInputAmountDropdown } from '../components/input-amount-dropdown/src/LionInputAmountDropdown.js'; | |||
There was a problem hiding this comment.
Also need to add input-amount-dropdown-test-helpers.js and input-amount-dropdown-test-suites.js` to the export folder to make the tests run.
What I did
input-amount-dropdowntest cases and suite to define the spec of the new component, according to the pre-existinginput-tel-dropdownstructure.CurrencyUtilManager, according toPhoneUtilManagerto handle all possible currency codes.