fix(validate-mixin): determine required or result validators based on characteristics #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dator has been registered based on characteristics
🦋 Changeset detectedLatest commit: a830c83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
tlouisse
reviewed
Mar 21, 2025
| @@ -130,6 +130,121 @@ export function runValidateMixinSuite(customConfig) { | |||
| expect(el.hasFeedbackFor).to.deep.equal(['error']); | |||
| }); | |||
|
|
|||
| it('determines whether the "Required" validator was already handled by judging the validatorName', async () => { | |||
| class BundledValidator extends EventTarget { | |||
There was a problem hiding this comment.
Could you maybe extend from the Validator class here (to set the right example in tesrs as well?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
ValidateMixin.jsa combination of approaches was used to determine if aRequiredvalidator is aRequiredvalidator, so that the validation routines can be executed accordingly. This involved:instanceofapproach (initial, changed later by fix: form validators check and disabled prop #2397).validatorName(introduced by fix: form validators check and disabled prop #2397)However, an
instanceofcheck still remained in the__executeValidatorsfunction. This PR aims to unify the approach inValidateMixin.js.What I did
When classifying the passed validators (in
MetaValidators,AsyncValidators,SyncValidators), both theRequiredcheck and theMetaValidatorchecks are now done via characteristics of each:Requiredvalidator should have.validatorName === 'Required'MetaValidatorshould present a.executeOnResultsfunctionImproved some JSDOC type annotations
Added 2 new test cases in
ValidateMixin.suite.js:Requiredvalidator which is bundled (as an example) should keep working, while with aninstanceofcheck, the test would fail in this caseResultValidator(in this caseDefaultSuccess)