Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run tests & linting on master #232

Merged
merged 1 commit into from
Apr 21, 2020
Merged

ci: run tests & linting on master #232

merged 1 commit into from
Apr 21, 2020

Conversation

tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Apr 21, 2020 •
edited
Loading

run rust ci on master

closes #231

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@tac0turtle tac0turtle changed the title make rust ci run on master ci: run tests & linting on master Apr 21, 2020
liamsi
liamsi approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks! I'm surprised to see the integration tests failing but this is orthogonal to this PR. Will open a separate issue.

@liamsi liamsi merged commit 4936d18 into informalsystems:master Apr 21, 2020
@liamsi liamsi mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI]: checks on master
2 participants
@tac0turtle @liamsi