Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump serde-wasm-bindgen, js-sys to fix broken compile #1481

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

SuperFluffy
Copy link
Contributor

@SuperFluffy SuperFluffy commented Dec 12, 2024

Fixes failing compilation of wasm-bindgest-test by bumping serde-wasm-bindgen@v0.6.5 and js-sys@=v0.3.70 (see compilation error at the bottom of these patch notes).

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests (formerly broken compiles work now)
  • Added entry in .changelog/
Compilation errors seen in CI:
error[E0152]: found duplicate lang item `panic_impl`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasm-bindgen-test-0.3.49/src/rt/mod.rs:321:9
    |
321 | /         fn panic_handler(panic_info: &core::panic::PanicInfo<'_>) -> ! {
322 | |             panic_handling(panic_info.to_string());
323 | |             core::arch::wasm32::unreachable();
324 | |         }
    | |_________^
    |
    = note: the lang item is first defined in crate `std` (which `js_sys` depends on)
    = note: first definition in `std` loaded from /home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown/lib/libstd-89e63d1941b447bf.rlib
    = note: second definition in the local crate (`wasm_bindgen_test`)

For more information about this error, try `rustc --explain E0152`.
error: could not compile `wasm-bindgen-test` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Compilation of your program failed
Caused by: Compilation of your program failed
Caused by: failed to execute `cargo build`: exited with exit status: 101
  full command: cd "./light-client-js/" && "cargo" "build" "--tests" "--target" "wasm32-unknown-unknown"

@SuperFluffy SuperFluffy marked this pull request as ready for review December 12, 2024 13:53
@SuperFluffy
Copy link
Contributor Author

Looks like CI failed due to a (potential) network error. I don't have permissions to kick the job to see if it's real.

@romac romac merged commit 78553cd into informalsystems:main Dec 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants