rpc: Allow empty JSON object value for consensus_param_updates in /block_results response
#1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
approved these changes
Jul 11, 2024
|
Thanks! Can we also fix this while we are at it? tendermint-rs/tendermint/src/consensus/params.rs Lines 19 to 20 in ed576f2 |
Oh I missed that sorry. I'll fix it |
romac
reviewed
Jul 11, 2024
tendermint/src/lib.rs
Outdated
| @@ -35,6 +35,7 @@ pub mod chain; | |||
| pub mod channel; | |||
| pub mod consensus; | |||
| pub mod crypto; | |||
| pub mod deserializers; | |||
There was a problem hiding this comment.
Let's add it to the serializers instead, to help discovery.
…osis fixture test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1440
This PR adds a custom deserializer for the
consensus_param_updatesfield in the/block_resultsresponse to deserialize bothnulland an empty JSON object toNone.E.g. both of these will successfully deserialize to
None:{"consensus_param_updates": {}}{"consensus_param_updates": null}Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Added entry in
.changelog/