Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix new warnings #1388

Merged
merged 13 commits into from
Jan 26, 2024
Merged

Update dependencies and fix new warnings #1388

merged 13 commits into from
Jan 26, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jan 24, 2024

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (194d81e) 59.0% compared to head (5c3b94a) 58.6%.
Report is 2 commits behind head on main.

❗ Current head 5c3b94a differs from pull request most recent head 9115d09. Consider uploading reports for the commit 9115d09 to get more accurate results

Files Patch % Lines
tendermint/src/chain/id.rs 0.0% 1 Missing ⚠️
tendermint/src/error.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1388     +/-   ##
=======================================
- Coverage   59.0%   58.6%   -0.5%     
=======================================
  Files        275     275             
  Lines      27930   28379    +449     
=======================================
+ Hits       16505   16633    +128     
- Misses     11425   11746    +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac
Copy link
Member Author

romac commented Jan 24, 2024

I had to revert the version bump of serde-wasm-bindgen, as the light-client-js tests were failing and I have been unable to run them locally nor in a arm64/amd64 Docker container.

@romac romac merged commit 3b68a23 into main Jan 26, 2024
25 checks passed
@romac romac deleted the romac/updates-and-fixes branch January 26, 2024 06:24
mzabaluev added a commit that referenced this pull request Feb 21, 2024
A partial backport of #1388, non-breaking changes only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants