Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespace field to Tx sync and async Response #1383

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Dec 7, 2023

Closes: #1382

This PR adds the codespace field to Tx sync and async Response which gives additional information on the source of the error.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (194d81e) 59.0% compared to head (40e784e) 59.1%.

❗ Current head 40e784e differs from pull request most recent head 2b81c8b. Consider uploading reports for the commit 2b81c8b to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1383   +/-   ##
=====================================
  Coverage   59.0%   59.1%           
=====================================
  Files        275     275           
  Lines      27930   28004   +74     
=====================================
+ Hits       16505   16561   +56     
- Misses     11425   11443   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljoss17 ljoss17 requested review from romac and mzabaluev December 7, 2023 09:22
@romac romac merged commit a21b245 into main Dec 11, 2023
23 checks passed
@romac romac deleted the luca_joss/add-codespace-to-tx-response branch December 11, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code space to Tx sync and async Response
3 participants