Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client: Replace serde_cbor with serde_json #1133

Merged
merged 3 commits into from
Jun 1, 2022
Merged

light-client: Replace serde_cbor with serde_json #1133

merged 3 commits into from
Jun 1, 2022

Conversation

devashishdxt
Copy link

@devashishdxt devashishdxt commented May 25, 2022

Fixes #1026.
Fixes #1038.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@devashishdxt devashishdxt changed the title Replace serde_cbor with serde_json light-client: Replace serde_cbor with serde_json May 25, 2022
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bice, just a small nit.

light-client/Cargo.toml Outdated Show resolved Hide resolved
@devashishdxt devashishdxt requested a review from xla May 26, 2022 09:29
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

٩(˘◡˘)۶

@codecov-commenter
Copy link

Codecov Report

Merging #1133 (088f320) into master (cd3e391) will not change coverage.
The diff coverage is 83.3%.

@@          Coverage Diff           @@
##           master   #1133   +/-   ##
======================================
  Coverage    64.7%   64.7%           
======================================
  Files         231     231           
  Lines       15637   15637           
======================================
  Hits        10121   10121           
  Misses       5516    5516           
Impacted Files Coverage Δ
light-client/src/store/sled/utils.rs 72.0% <66.6%> (ø)
light-client/src/errors.rs 84.2% <100.0%> (ø)
testgen/src/vote.rs 84.8% <0.0%> (-0.9%) ⬇️
testgen/src/light_block.rs 76.6% <0.0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3e391...088f320. Read the comment docs.

@xla xla merged commit 27e7f60 into informalsystems:master Jun 1, 2022
@devashishdxt
Copy link
Author

@xla This PR was merged but I don't see these changes in main branch.

@thanethomson
Copy link
Contributor

main is effectively a fork off of tendermint-rs v0.23.x, since Tendermint Core v0.35/v0.36 were abandoned. See #1179

This would need to be ported across to main again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0127: serde_cbor is unmaintained Use an alternative crate for serde_cbor
4 participants