Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sha2 to v0.10; replace ripemd160 with ripemd v0.1 #1130

Merged
merged 2 commits into from
May 11, 2022

Conversation

tony-iqlusion
Copy link
Collaborator

These crates are both based on digest v0.10, which is also the same version used by k256 v0.11 (#1129).

Note that the ripemd160 crate is now deprecated:

https://docs.rs/ripemd160/latest/ripemd160/

The ripemd crate is the replacement. It has the same maintainers (@RustCrypto), but now combines the former ripemd160 and ripemd320 crates into a single crate.

These crates are both based on `digest` v0.10, which is also the same
version used by `k256` v0.11 (#1129).

Note that the `ripemd160` crate is now deprecated:

https://docs.rs/ripemd160/latest/ripemd160/

The `ripemd` crate is the replacement. It has the same maintainers
(@RustCrypto), but now combines the former `ripemd160` and `ripemd320`
crates into a single crate.
@tony-iqlusion tony-iqlusion requested a review from thanethomson May 9, 2022 21:36
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #1130 (4354e20) into master (a453e6e) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1130   +/-   ##
======================================
  Coverage    64.7%   64.7%           
======================================
  Files         231     231           
  Lines       15637   15637           
======================================
+ Hits        10121   10127    +6     
+ Misses       5516    5510    -6     
Impacted Files Coverage Δ
tendermint/src/account.rs 91.0% <ø> (ø)
testgen/src/header.rs 87.5% <0.0%> (-1.3%) ⬇️
testgen/src/vote.rs 84.8% <0.0%> (-0.9%) ⬇️
testgen/src/light_block.rs 76.6% <0.0%> (+0.5%) ⬆️
config/src/config.rs 67.0% <0.0%> (+4.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a453e6e...4354e20. Read the comment docs.

xla
xla previously approved these changes May 10, 2022
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍(◔◡◔)

@thanethomson thanethomson merged commit cd3e391 into master May 11, 2022
@thanethomson thanethomson deleted the digest/v0.10-crates branch May 11, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants