Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Add audit config #1119

Merged
merged 1 commit into from
Apr 9, 2022
Merged

meta: Add audit config #1119

merged 1 commit into from
Apr 9, 2022

Conversation

xla
Copy link
Contributor

@xla xla commented Apr 9, 2022

Add an explicit audit config to control its behaviour, also ignore
advisory for serde_cbor until resolved.

Signed-off-by: xla self@xla.is

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
    * [ ] Wrote tests
    * [ ] Added entry in .changelog/

Add an explicit audit config to control its behaviour, also ignore
advisory for serde_cbor until resolved.

Signed-off-by: xla <self@xla.is>
@xla xla self-assigned this Apr 9, 2022
@xla xla mentioned this pull request Apr 9, 2022
4 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1119 (38a97b5) into master (d2b9f33) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #1119     +/-   ##
========================================
- Coverage    64.8%   64.7%   -0.1%     
========================================
  Files         240     240             
  Lines       20822   20822             
========================================
- Hits        13500   13492      -8     
- Misses       7322    7330      +8     
Impacted Files Coverage Δ
testgen/src/vote.rs 84.0% <0.0%> (-1.7%) ⬇️
abci/src/codec.rs 87.8% <0.0%> (-1.4%) ⬇️
p2p/src/secret_connection/protocol.rs 59.8% <0.0%> (-1.0%) ⬇️
light-client-verifier/src/types.rs 38.2% <0.0%> (-0.9%) ⬇️
testgen/src/validator.rs 86.7% <0.0%> (-0.8%) ⬇️
testgen/src/commit.rs 90.6% <0.0%> (-0.7%) ⬇️
testgen/src/light_block.rs 76.1% <0.0%> (-0.6%) ⬇️
abci/src/server.rs 8.8% <0.0%> (-0.4%) ⬇️
tendermint/src/node.rs 63.6% <0.0%> (-0.2%) ⬇️
tendermint/src/evidence.rs 25.3% <0.0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b9f33...38a97b5. Read the comment docs.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@thanethomson thanethomson merged commit 6bb8855 into master Apr 9, 2022
@thanethomson thanethomson deleted the xla/1026-add-audit-meta branch April 9, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants