Add support for tendermint::chain::Id constants
#1105
Conversation
|
If you're happy with the general direction I can add some tests for this specific constructor. |
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
========================================
- Coverage 64.7% 64.7% -0.1%
========================================
Files 240 240
Lines 20789 20808 +19
========================================
+ Hits 13464 13466 +2
- Misses 7325 7342 +17
Continue to review full report at Codecov.
|
cd1f6c6 to
cc889be
Compare
Seems good to me! |
In PeggyJV/ocular#18 we are trying to create a registry of "well-known" chain IDs. I proposed using `tendermint::chain::Id` for this, but to do so we'd need to have a const initializer support. This commit changes the internal representation of `chain::Id` to `Cow<'static, str>`. This permits a `const fn` initializer, but avoids adding a lifetime to `chain::Id` itself. It also adds `chain::Id::new` which is defined as a `const fn`, which can be used to define chain ID constants.
cc889be to
50ec5ce
Compare
|
Tests and changelog entry added |
| const MAX_LENGTH_CHAIN_ID: &str = "01234567890123456789012345678901234567890123456789"; | ||
| const OVERLENGTH_CHAIN_ID: &str = "012345678901234567890123456789012345678901234567890"; |
There was a problem hiding this comment.
These need to be constants to test Id::new, which accepts a &'static str as an argument.
| assert!( | ||
| matches!( |
There was a problem hiding this comment.
Soon: assert_matches!
In PeggyJV/ocular#18 we are trying to create a registry of "well-known" chain IDs. I proposed using
tendermint::chain::Idfor this, but to do so we'd need to have a const initializer support.This commit changes the internal representation of
chain::IdtoCow<'static, str>. This permits aconst fninitializer, but avoids adding a lifetime tochain::Iditself.It also adds
chain::Id::newwhich is defined as aconst fn, which can be used to define chain ID constants..changelog/