Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump getrandom to 0.2 #1062

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Dec 20, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #1062 (9ca8a44) into master (c45ea8c) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 9ca8a44 differs from pull request most recent head f7f6075. Consider uploading reports for the commit f7f6075 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1062     +/-   ##
========================================
- Coverage    62.8%   62.7%   -0.1%     
========================================
  Files         236     236             
  Lines       21218   21218             
========================================
- Hits        13328   13320      -8     
- Misses       7890    7898      +8     
Impacted Files Coverage Δ
tendermint/src/evidence.rs 21.6% <0.0%> (-3.8%) ⬇️
testgen/src/vote.rs 84.8% <0.0%> (-0.9%) ⬇️
light-client/src/types.rs 38.0% <0.0%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45ea8c...f7f6075. Read the comment docs.

@@ -62,7 +62,7 @@ websocket-client = [

[dependencies]
bytes = { version = "1.0", default-features = false }
getrandom = { version = "0.1", default-features = false }
getrandom = { version = "0.2", default-features = false, features = ["js"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs:

if the "js" Cargo feature is enabled, this crate will assume that you are building for an environment containing JavaScript, and will call the appropriate methods. Both web browser (main window and Web Workers) and Node.js environments are supported, invoking the methods described above using the wasm-bindgen toolchain.

This feature has no effect on targets other than wasm32-unknown-unknown.

Seems reasonable to enable this feature, thanks!

@thanethomson thanethomson merged commit f6451a7 into informalsystems:master Dec 20, 2021
thanethomson pushed a commit that referenced this pull request Dec 20, 2021
thanethomson added a commit that referenced this pull request Dec 20, 2021
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants