Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Remove ErrorDetail::Server #1040

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Dec 1, 2021

This does not seem to be produced anywhere.

Fixes: #1039

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

This does not seem to be produced anywhere.
@mzabaluev mzabaluev added rpc breaking code-quality Issues relating to linting configuration and general code quality labels Dec 1, 2021
@mzabaluev mzabaluev requested a review from soareschen December 1, 2021 11:00
@mzabaluev mzabaluev merged commit 0a53b18 into master Dec 2, 2021
@mzabaluev mzabaluev deleted the mikhail/we-dont-believe-in-server-errors branch December 2, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking code-quality Issues relating to linting configuration and general code quality rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc: ErrorDetail::Server is unused
2 participants