Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and repo config for new versioning approach #1020

Merged
merged 16 commits into from
Nov 26, 2021

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Nov 16, 2021

Related to #1018.

This PR updates the repo documentation (README, contributing guidelines, ADR docs, PR and issue templates) to (1) better reflect how we currently work, and (2) accommodate the new versioning approach.

Note that I've taken out the RFC-related documentation from the contributing guidelines because we don't do RFCs. I think it complicates the contributing guidelines as well.

Rendered versions:

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson changed the title Repository and documentation update to accommodate new versioning approach Update docs and repo config for new versioning approach Nov 16, 2021
@thanethomson thanethomson marked this pull request as ready for review November 16, 2021 02:01
@thanethomson thanethomson marked this pull request as draft November 17, 2021 13:19
@thanethomson
Copy link
Contributor Author

Changed this back to a draft PR to accommodate recent feedback on the versioning approach here.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested review from mzabaluev and romac and removed request for ebuchman and liamsi November 26, 2021 17:56
@thanethomson thanethomson marked this pull request as ready for review November 26, 2021 17:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #1020 (60a7f90) into master (9690eca) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1020     +/-   ##
========================================
- Coverage    66.1%   66.0%   -0.1%     
========================================
  Files         209     209             
  Lines       20764   20760      -4     
========================================
- Hits        13726   13721      -5     
- Misses       7038    7039      +1     
Impacted Files Coverage Δ
config/src/config.rs 55.0% <0.0%> (-1.5%) ⬇️
tendermint/src/proposal.rs 90.4% <0.0%> (-0.3%) ⬇️
tendermint/src/test.rs 100.0% <0.0%> (ø)
tendermint/src/node.rs 63.7% <0.0%> (+0.1%) ⬆️
abci/src/server.rs 9.8% <0.0%> (+0.2%) ⬆️
tendermint/src/vote.rs 76.6% <0.0%> (+0.3%) ⬆️
tendermint/src/signature.rs 55.0% <0.0%> (+0.5%) ⬆️
testgen/src/vote.rs 84.8% <0.0%> (+0.8%) ⬆️
testgen/src/header.rs 80.9% <0.0%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9690eca...60a7f90. Read the comment docs.

…0.23.x

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit 711ea34 into master Nov 26, 2021
@thanethomson thanethomson deleted the thane/repo-admin branch November 26, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants