Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Move value_payload in test config #847

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Feb 11, 2025

Closes: #835


PR author checklist

For all contributors

For external contributors

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (99124f5) to head (5d722c9).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   81.69%   81.62%   -0.06%     
==========================================
  Files         182      182              
  Lines       16266    16263       -3     
==========================================
- Hits        13287    13274      -13     
- Misses       2979     2989      +10     
Flag Coverage Δ
integration 81.46% <ø> (-0.07%) ⬇️
mbt 8.51% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

@romac romac marked this pull request as ready for review February 12, 2025 10:06
@romac romac requested a review from greg-szabo as a code owner February 12, 2025 10:06
@romac romac added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 59b3d4f Feb 12, 2025
23 checks passed
@romac romac deleted the anca/value_payload branch February 12, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Remove value_payload option from the config
2 participants