Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: utilize encoded bytes from Any for header of UpdateClient event #822

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Aug 7, 2023

Closes: #821
Integration tests: informalsystems/basecoin-rs#123


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (b442703) 71.49% compared to head (c8c327e) 71.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files         124      124           
  Lines       14960    14960           
=======================================
  Hits        10696    10696           
  Misses       4264     4264           
Files Changed Coverage Δ
crates/ibc/src/core/ics02_client/events.rs 71.42% <66.66%> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 95.45% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review August 7, 2023 22:46
@Farhad-Shabani Farhad-Shabani requested a review from plafer August 7, 2023 22:46
yito88 added a commit to heliaxdev/cosmos-ibc-rs that referenced this pull request Aug 8, 2023
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@plafer plafer merged commit 5c48d15 into main Aug 8, 2023
@plafer plafer deleted the farhad/fix-decoding-header-issue branch August 8, 2023 16:08
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
…ent (#822)

* fix: utilize encoded bytes from Any for header of UpdateClient event

* nit: use header_bytes

* nit: edit unclog

* nit: add a docstring for UpdateClient event

* imp: use encode_to_vec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

header decoding from emitted UpdateClient event fails
2 participants