Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 005 & ADR 003 update #497

Merged
merged 14 commits into from
Feb 24, 2021
Merged

ADR 005 & ADR 003 update #497

merged 14 commits into from
Feb 24, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Jan 4, 2021

Closes: #326
Closes: #548

ADR 005 rendered


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere changed the title Adi/326 adr05 ADR 005 Jan 4, 2021
@codecov-io
Copy link

codecov-io commented Jan 4, 2021

Codecov Report

Merging #497 (53684ef) into master (b1b37f5) will increase coverage by 32.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #497      +/-   ##
=========================================
+ Coverage    13.6%   46.4%   +32.7%     
=========================================
  Files          69     151      +82     
  Lines        3752   10165    +6413     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4722    +4209     
- Misses       2618    5443    +2825     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
modules/src/address.rs 100.0% <ø> (ø)
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 48.3% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae36bba...f56430f. Read the comment docs.

@brapse
Copy link
Contributor

brapse commented Feb 5, 2021

Lets get this merged 🎉

@adizere adizere marked this pull request as ready for review February 12, 2021 17:54
@adizere adizere changed the title ADR 005 ADR 005 & ADR 003 update Feb 12, 2021
Copy link
Contributor

@brapse brapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brapse brapse merged commit 3757b65 into master Feb 24, 2021
@brapse brapse deleted the adi/326_adr05 branch February 24, 2021 15:54
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Skeleton

* Initial nits

* ADR 005 first draft

* refs and architecture diagram redone

* Added new arch picture

* Size down arch image

* Unify image format

* Renamed the ADR, design goals

* Add mention to dev-time env

* Update ADR 005

* Minor improvements, should be ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADR 003 update to reflect recent changes around Events ADR for Relayer v0 Concurrency Architecture
3 participants