Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS 4: Messages split #394

Merged
merged 2 commits into from
Nov 11, 2020
Merged

ICS 4: Messages split #394

merged 2 commits into from
Nov 11, 2020

Conversation

adizere
Copy link
Member

@adizere adizere commented Nov 11, 2020

Part of cosmos/ibc-rs#105

This PR only handles effectively splitting the messages into separate modules.
PR #391 handles the addition of domain types and new tests.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue. not needed yet since no issue is closed.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Haven't checked all line by line though :) I assume nothing else has changed.

@adizere adizere merged commit 49129e5 into master Nov 11, 2020
@adizere adizere deleted the adi/315_ics4_types_split branch November 11, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants