Set CompatMode fallback to v0.34 when the version query fails #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Oct 19, 2023
.changelog/unreleased/improvements/ibc-relayer/3666-default-compat-mode-to-v034.md
Outdated
Show resolved
Hide resolved
romac
approved these changes
Oct 19, 2023
Signed-off-by: Romain Ruetschi <github@romac.me>
|
Thanks for this @ljoss17 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3666
Description
The node information is retrieved with the
/statusquery and the version is used to define theCompatMode. If the version retrieved by the query isn't v0.34 or v0.37, the previous fallback value was v0.37.This PR update the fallback value to v0.34 in order to allow relaying for chains such as Celestia.
This is temporary as there will be a new configuration to specify the
CompatModeversion #3623PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.