Implement client update and fix client create CLIs #355

ancazamfir · 2020-11-02T11:47:34Z

Closes: #277 informalsystems/ibc-rs#103

Description

Here is a summary of the changes:

pointing to branch greg/research-json where the tendermint changes for stargate-4 are and tendermint domain types are implemented for the IBC dependencies (validator set, consensus params, etc)
removed unneeded serde (de)serializers
refactored a bit the conversion between accountId and String. We should change the signer type to String in handlers as any validation and use of this happens before the hanlers are invoked. Code will be simpler and we could remove the address.rs
defined domain types for AnyHeader, MsgUpdateAnyClient, ics07 header,
update tendermint client_state with stargate-4 required fields and impls
implement get_sign_bytes() in Msg trait
add update client CLI
refactor the Tx CLIs to take typed input, remove Option from positional params.
add client message builder to chain impl of cosmos
add connection init message builder to chain trait
some refactor of chain methods. We should sit down and review what goes in Chain vs impl Chain for CosmosSDK vs impl CosmosSDK. I guess these would move to the ChainHandle but the approach should be the same.
some changes in tests and refactor of the different test utils.

TODO:

update changelog
split client msgs.rs file before merging. -> deferred to Update sp-runtime requirement from 14.0.0 to 15.0.0 in /ci/no-std-check ibc-rs#367

For contributor use:

Updated the Unreleased section of CHANGELOG.md with the issue.
If applicable: Unit tests written, added test to CI.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments.
Re-reviewed Files changed in the Github PR explorer.

Cleanup and tests Add query_consensus_params() and fix query_header_at_height() in cosmos chain Refactor a bit the accnt seq and key-seed code Update signed_header.json with valid signed header Hardcode cosmos ics23 specs for create client msg Remove ics07 messages Fix create client params and filling Impl domain type for MsgUpdateAnyClient Add update client CLI Impl domain type for ics02 AnyHeader and ics07 Header Add type-url constants Make changes to compile Use local tendermint-rs based on Greg's branch

codecov-io · 2020-11-03T10:35:47Z

Codecov Report

Merging #355 into master will increase coverage by 20.9%.
The diff coverage is 64.5%.

@@            Coverage Diff            @@
##           master    informalsystems/hermes#355      +/-   ##
=========================================
+ Coverage    13.6%   34.6%   +20.9%     
=========================================
  Files          69     143      +74     
  Lines        3752    9048    +5296     
  Branches     1374    3053    +1679     
=========================================
+ Hits          513    3132    +2619     
- Misses       2618    5676    +3058     
+ Partials      621     240     -381

Impacted Files	Coverage Δ
modules/src/events.rs	`0.0% <0.0%> (ø)`
modules/src/ics02_client/events.rs	`0.0% <ø> (ø)`
modules/src/ics02_client/msgs.rs	`0.0% <0.0%> (ø)`
modules/src/ics02_client/raw.rs	`0.0% <0.0%> (ø)`
modules/src/ics03_connection/error.rs	`13.6% <0.0%> (-19.7%)`	⬇️
modules/src/ics04_channel/error.rs	`75.0% <ø> (+50.0%)`	⬆️
modules/src/ics04_channel/packet.rs	`0.0% <0.0%> (ø)`
modules/src/ics07_tendermint/client_def.rs	`0.0% <0.0%> (ø)`
modules/src/ics07_tendermint/error.rs	`75.0% <ø> (+75.0%)`	⬆️
modules/src/ics18_relayer/error.rs	`0.0% <0.0%> (ø)`
... and 264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f314e5...50dae06. Read the comment docs.

modules/src/ics03_connection/msgs/conn_open_init.rs

modules/src/ics02_client/msgs.rs

modules/src/tx_msg.rs

relayer/src/chain.rs

relayer/src/tx/client.rs

relayer-cli/src/commands/tx/client.rs

relayer-cli/src/commands/tx/connection.rs

romac · 2020-11-03T12:08:42Z

@ancazamfir Amazing job by the way :)

adizere

Cool stuff!

Left a few ideas on how we can continue this work + do a bit of cleanup, but this is almost ready.

modules/src/address.rs

modules/src/ics03_connection/connection.rs

modules/src/ics03_connection/msgs.rs

modules/src/ics03_connection/msgs/conn_open_init.rs

modules/src/ics07_tendermint/client_state.rs

modules/src/ics24_host/identifier.rs

relayer/src/chain/cosmos.rs

relayer/src/tx/connection.rs

adizere

Thanks Anca for the replies & updates. Looks good!

* Initial commit of client txs Cleanup and tests Add query_consensus_params() and fix query_header_at_height() in cosmos chain Refactor a bit the accnt seq and key-seed code Update signed_header.json with valid signed header Hardcode cosmos ics23 specs for create client msg Remove ics07 messages Fix create client params and filling Impl domain type for MsgUpdateAnyClient Add update client CLI Impl domain type for ics02 AnyHeader and ics07 Header Add type-url constants Make changes to compile Use local tendermint-rs based on Greg's branch * Switch to tendermint repo branch * restructure and cleanup * move client message builder to chain * move conn init message builder to chain * Implement get_sign_bytes() in Msg trait, add to_any() and type_url() * cleanup * add forgotten test_utils * Better error handling in ibc::address * Formatting * Add missing Eq bounds where possible * rearrange the conn-init positional params and the chain handling * review comments * Move the client msg builder out of chain * Split client msgs * Move unbonding_period to impl CosmosSDK * Updated changelog * Fix for upstream changes (optional version in consensus::Params). Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Adi Seredinschi <adi@informal.systems>

ancazamfir added 7 commits October 30, 2020 18:15

Switch to tendermint repo branch

bfff9d4

restructure and cleanup

2178c27

move client message builder to chain

993a2d3

move conn init message builder to chain

0619cda

Implement get_sign_bytes() in Msg trait, add to_any() and type_url()

b47389a

cleanup

883ac56

ancazamfir requested a review from romac as a code owner November 2, 2020 11:47

ancazamfir requested review from adizere and andynog November 2, 2020 11:47

ancazamfir and others added 2 commits November 2, 2020 15:10

add forgotten test_utils

2ae8531

Better error handling in ibc::address

ae5f2c5

romac added 2 commits November 3, 2020 11:37

Formatting

f4f0af0

Add missing Eq bounds where possible

921ddd3

romac reviewed Nov 3, 2020

View reviewed changes

rearrange the conn-init positional params and the chain handling

9c8a248

romac reviewed Nov 3, 2020

View reviewed changes

relayer-cli/src/commands/tx/client.rs Outdated Show resolved Hide resolved

romac reviewed Nov 3, 2020

View reviewed changes

relayer-cli/src/commands/tx/client.rs Outdated Show resolved Hide resolved

romac reviewed Nov 3, 2020

View reviewed changes

relayer-cli/src/commands/tx/connection.rs Outdated Show resolved Hide resolved

adizere reviewed Nov 3, 2020

View reviewed changes

review comments

0a32206

adizere approved these changes Nov 4, 2020

View reviewed changes

ancazamfir added 4 commits November 4, 2020 09:55

Move the client msg builder out of chain

eb128d9

Merge branch 'master' into anca/client_clis_new

2bc8230

Split client msgs

5d5bc42

Move unbonding_period to impl CosmosSDK

7ee9085

adizere mentioned this pull request Nov 5, 2020

Split the msgs.rs in ICS02 in separate modules #367

Closed

5 tasks

Updated changelog

bae97ed

Fix for upstream changes (optional version in consensus::Params).

50dae06

adizere merged commit 12cb1d6 into master Nov 5, 2020

adizere deleted the anca/client_clis_new branch November 5, 2020 18:58

This was referenced Nov 5, 2020

Fix master by pinning against tendermint-rs 0.17-RC2 #368

Closed

Clippy practices #375

Closed

Remove signer field from domain type messages #219

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement client update and fix client create CLIs #355

Implement client update and fix client create CLIs #355

ancazamfir commented Nov 2, 2020 •

edited by adizere

Loading

codecov-io commented Nov 3, 2020 •

edited

Loading

romac commented Nov 3, 2020

adizere left a comment

adizere left a comment

Implement client update and fix client create CLIs #355

Implement client update and fix client create CLIs #355

Conversation

ancazamfir commented Nov 2, 2020 • edited by adizere Loading

Description

codecov-io commented Nov 3, 2020 • edited Loading

Codecov Report

romac commented Nov 3, 2020

adizere left a comment

Choose a reason for hiding this comment

adizere left a comment

Choose a reason for hiding this comment

ancazamfir commented Nov 2, 2020 •

edited by adizere

Loading

codecov-io commented Nov 3, 2020 •

edited

Loading