Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the ibc crate now uses the local ibc-proto crate #239

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

greg-szabo
Copy link
Member

Closes: cosmos/ibc-proto-rs#23

Description

The ibc crate (modules folder) now uses the ibc-proto crate defined in this repository. (proto folder).

I also updated the version in html_url for ibc-proto but it's too late for v0.3.0. We should make sure we update it in the next release.


For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

modules/Cargo.toml Outdated Show resolved Hide resolved
@romac romac self-requested a review September 18, 2020 11:22
@romac romac merged commit 2abf34a into master Sep 18, 2020
@romac romac deleted the greg/local-proto branch September 18, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ibc-proto source code into ibc-rs
3 participants