Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC-proto crate #238

Merged
merged 7 commits into from
Sep 17, 2020
Merged

IBC-proto crate #238

merged 7 commits into from
Sep 17, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Sep 17, 2020 •
edited
Loading

Closes: cosmos/ibc-proto-rs#23

Description

  • Moves ibc-proto repository into ibc-rs.
    • proto folder for the ibc-proto crate
    • proto-compiler folder for the unpublished ibc-proto-compiler
    • proto-derive folder for the derive macro (we could remove this if we published tendermint-proto-derive)
  • Adds git clone functionality to proto-compiler. No need for Makefiles anymore.
  • Moves custom protobuf files under proto/definitions.
  • Adds the DomainType trait also introduced in Tendermint-rs.

For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@greg-szabo greg-szabo changed the title Greg/proto IBC-proto crate Sep 17, 2020
@greg-szabo greg-szabo marked this pull request as ready for review September 17, 2020 17:39
ancazamfir
ancazamfir approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yupeee! Looks great! I used the version with the generated file, tests pass. With my limited knowledge on what was in ibc-proto before, looks great and I am looking forward to seeing it on master!

@greg-szabo greg-szabo merged commit 4be6f3d into master Sep 17, 2020
@greg-szabo greg-szabo deleted the greg/proto branch September 17, 2020 19:45
@romac romac mentioned this pull request Sep 18, 2020
Closed
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@greg-szabo
IBC-proto crate (informalsystems#238)
9bfeb7d 
* IBC-proto move over

* proto-compiler crate

* DomainType copied from Tendermint-rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ibc-proto source code into ibc-rs
2 participants
@greg-szabo @ancazamfir