-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Hermes v1.0.0-rc.0 #2355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unreceived-acks` to `query pending-acks`
romac
requested review from
adizere,
seanchen1991,
ancazamfir,
mzabaluev,
soareschen,
hu55a1n1 and
plafer
as code owners
July 6, 2022 16:48
hu55a1n1
reviewed
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @romac! Left some questions and minor nits.
soareschen
approved these changes
Jul 7, 2022
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
hu55a1n1
approved these changes
Jul 7, 2022
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Update top-level modules doc comments in ibc-relayer-cli * Update lockfile * Improve `spawn_chain_runtime_*` functions doc comments * Rename `query unreceived-packets` to `query pending-sends` and `query unreceived-acks` to `query pending-acks` * Fix misfiled changelog entry and add `ibc-telemetry` component * Add changelog entry for informalsystems#2379 * Bump `ibc-proto` version to 0.19.0 * Bump crates to v0.16.0 * Bump Hermes to v1.0.0-rc.0 * Update lockfile * Release changelog * Add UPGRADING document * Update changelog * Manually restructure the CHANGELOG * Apply suggestions from review Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Soares Chen <soares.chen@maybevoid.com> * Change unreceived to pending in the guide * Fix line numbers in link * Fix header in changelog Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2265
Closes: #2379
Cleanup & dependencies
The presentation for the
ibc-relayer-cli
crate is very minimal, we should improve that; we should signal clearly what each module is for and look for obvious boilerplate content to make it more specific or remove it from the documentationFix inconsistency between
query packet pending
andquery packet unreceived-acks
/unreceived-packets
#2379⚡
The usual todos
unclog
.rc
) version, then skip theunclog release
step.ibc-relayer-cli
)