Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw wrapper around tx subcommands #2337

Closed
wants to merge 1 commit into from
Closed

Remove raw wrapper around tx subcommands #2337

wants to merge 1 commit into from

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #2315

Description

Remove Raw to Wrap tx subcommand.

below is removed the result.

➜  ibc-rs git:(davi-remove-raw-typo) ✗ cargo run -- tx --help
   Compiling ibc-relayer-cli v0.15.0 (/Users/davirain/informal-ibc/ibc-rs/relayer-cli)
    Finished dev [unoptimized + debuginfo] target(s) in 12.92s
     Running `target/debug/hermes tx --help`
hermes-tx
Create and send IBC transactions

USAGE:
    hermes tx <SUBCOMMAND>

OPTIONS:
    -h, --help    Print help information

SUBCOMMANDS:
    chan-close-confirm    Confirm the closing of a channel (ChannelCloseConfirm)
    chan-close-init       Initiate the closing of a channel (ChannelCloseInit)
    chan-open-ack         Relay acknowledgment of a channel attempt (ChannelOpenAck)
    chan-open-confirm     Confirm opening of a channel (ChannelOpenConfirm)
    chan-open-init        Initialize a channel (ChannelOpenInit)
    chan-open-try         Relay the channel attempt (ChannelOpenTry)
    conn-ack              Relay acknowledgment of a connection attempt (ConnectionOpenAck)
    conn-confirm          Confirm opening of a connection (ConnectionOpenConfirm)
    conn-init             Initialize a connection (ConnectionOpenInit)
    conn-try              Relay the connection attempt (ConnectionOpenTry)
    create-client         Create a client for source chain on destination chain
    ft-transfer           Send a fungible token transfer test transaction (ICS20 MsgTransfer)
    help                  Print this message or the help of the given subcommand(s)
    packet-ack            Relay acknowledgment packets
    packet-recv           Relay receive or timeout packets
    update-client         Update the specified client on destination chain
    upgrade-chain         Send an IBC upgrade plan
    upgrade-client        Upgrade the specified client on destination chain
    upgrade-clients       Upgrade all IBC clients that target a specific chain

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title Remove Raw Wrap Subcommand Remove raw wrapper around tx subcommands Jun 27, 2022
@adizere
Copy link
Member

adizere commented Jun 28, 2022

Thanks @DaviRain-Su ! We'll handle this PR after we do the v1 release (~1 week), because merging this PR would require we also update the guide, and that involves significant work. So it simplifies our life if we push these changes to post-v1. Hope that makes sense.

@adizere adizere added the A: blocked Admin: blocked by another (internal/external) issue or PR label Jun 28, 2022
@romac
Copy link
Member

romac commented Jul 14, 2022

@romac romac closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hermes tx raw commands to drop the raw subcommand
3 participants