Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for regression #1229 using new type ics02::TrustThreshold #1254

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Aug 2, 2021

Closes #1229

Description

  • Added a new domain type TrustThreshold in ICS02, which is an IBC-compliant representation of trust threshold.
  • re-enabled the chain and client upgrade CLIs

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Left a couple nitpicks but pre-approved

relayer/src/upgrade_chain.rs Outdated Show resolved Hide resolved
modules/src/ics02_client/error.rs Outdated Show resolved Hide resolved
modules/src/ics02_client/trust_threshold.rs Show resolved Hide resolved
adizere and others added 2 commits August 2, 2021 15:21
Co-authored-by: Romain Ruetschi <romain@informal.systems>
* Added markdown-link-check

* Update changelog

* Added config file

* Added ignore pattern for crates.io, simplified output

* Added ignore pattern for localhost

* Fix ignore patterns in markdown-link-check config

* Better Github relative link for directory

* Fix Github relative links within the project

* Fixed two broken links

* Fixed last broken link

* Reverted changelog

* Removed pending changelog file

Co-authored-by: Adi Seredinschi <adi@informal.systems>
@adizere adizere merged commit 6d170f4 into master Aug 2, 2021
@adizere adizere deleted the adi/1229-upgrade-clis branch August 2, 2021 13:40
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…reshold (informalsystems#1254)

* Fix for regression informalsystems#1229 using new type ics02::TrustThreshold

* Cleanup

* changelog

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Add CI job for finding invalid links in markdown files (informalsystems#1244)

* Added markdown-link-check

* Update changelog

* Added config file

* Added ignore pattern for crates.io, simplified output

* Added ignore pattern for localhost

* Fix ignore patterns in markdown-link-check config

* Better Github relative link for directory

* Fix Github relative links within the project

* Fixed two broken links

* Fixed last broken link

* Reverted changelog

* Removed pending changelog file

Co-authored-by: Adi Seredinschi <adi@informal.systems>

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Co-authored-by: Ranadeep Biswas <ranadeep@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLIs for upgrades regression following update to tm-rs 0.21
3 participants