Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tendermint-rs v0.21.0 #1223

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Update to tendermint-rs v0.21.0 #1223

merged 1 commit into from
Jul 21, 2021

Conversation

romac
Copy link
Member

@romac romac commented Jul 21, 2021

Closes: #1222

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac requested review from adizere and ancazamfir as code owners July 21, 2021 15:53
numerator: 0,
denominator: 0,
};
client_state.trust_level = TrustThresholdFraction::default();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adizere I took this from 0c797c8 but am not sure that this is right, since the Default instance for TrustThresholdFraction returns ONE_THIRD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this might break the chain upgrade CLI functionality! I'm aware of this and will keep it in mind for the parallel PR where we're also updating this CLI (#948) and will fix it there somehow.

For this PR, I think it should be fine.

@romac romac merged commit a0d9d4b into master Jul 21, 2021
@romac romac deleted the romac/tendermint-0.21 branch July 21, 2021 20:02
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to tendermint-rs 0.21.0
2 participants