Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ibc-proto requirement from the relayer #282

Closed
3 of 4 tasks
ancazamfir opened this issue Oct 5, 2020 · 0 comments · Fixed by #283
Closed
3 of 4 tasks

Remove ibc-proto requirement from the relayer #282

ancazamfir opened this issue Oct 5, 2020 · 0 comments · Fixed by #283
Assignees
@ancazamfir
Milestone
v0.0.4

Comments

@ancazamfir
Copy link
Collaborator

Summary of Bug

The dependency was introduce sometime during informalsystems/ibc-rs#246 but it's not needed anymore as the proto conversions are dealt with in the modules.

Version

all

Steps to Reproduce

Build and tests are fine without the depencency.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the v0.0.5 milestone Oct 5, 2020
@ancazamfir ancazamfir self-assigned this Oct 5, 2020
@ancazamfir ancazamfir mentioned this issue Oct 5, 2020
Merged
@adizere adizere modified the milestones: v0.0.5, v0.0.4 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
v0.0.4
Development

Successfully merging a pull request may close this issue.

Remove ibc-proto dependency from the relayer informalsystems/hermes
2 participants
@adizere @ancazamfir