Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calls to store_update_{time,height} should not be done in client handlers #246

Closed
plafer opened this issue Nov 16, 2022 · 1 comment
Closed
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Nov 16, 2022

Should be called in tendermint's implementation of ClientState.initialise(), as in ibc-go. We currently call it in the CreateClient handler and the UpdateClient handler.

@plafer plafer added the A: bug Admin: something isn't working label Nov 16, 2022
@plafer plafer changed the title calls to store_update_{time,height} should not be done in CreateClient handler calls to store_update_{time,height} should not be done in client handlers Nov 16, 2022
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
@plafer
Copy link
Contributor Author

plafer commented Feb 8, 2023

Also, the "processed time" is the block time of the last header. Instead of storing it as a separate value, couldn't we instead retrieve it from the last stored ConsensusState (which might require extra bookkeeping of its own, such as the height of the last update)?

@Farhad-Shabani Farhad-Shabani modified the milestone: Fix known bugs and issues Feb 8, 2023
@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants