Skip to content

Commit

Permalink
Disable upgrade client command due to a regression
Browse files Browse the repository at this point in the history
See #1229 for more info
  • Loading branch information
romac committed Jul 22, 2021
1 parent 3c383cf commit c145b25
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
8 changes: 8 additions & 0 deletions relayer-cli/src/commands/tx/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,15 @@ pub struct TxUpgradeClientCmd {
}

impl Runnable for TxUpgradeClientCmd {
#[allow(unreachable_code)]
fn run(&self) {
tracing::error!("This command is currently disabled due to a regression in Hermes v0.6.1.");
tracing::error!("Please track the following issue for background and progress:");
tracing::error!("");
tracing::error!(" https://github.com/informalsystems/ibc-rs/issues/1229");

std::process::exit(1);

let config = app_config();

let dst_chain = match spawn_chain_runtime(&config, &self.chain_id) {
Expand Down
12 changes: 7 additions & 5 deletions relayer-cli/src/commands/upgrade.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
use abscissa_core::{Command, Help, Options, Runnable};

use crate::commands::tx::client::{TxUpgradeClientCmd, TxUpgradeClientsCmd};
use crate::commands::tx::client::TxUpgradeClientCmd;

#[derive(Command, Debug, Options, Runnable)]
pub enum UpgradeCmds {
Expand All @@ -13,8 +13,10 @@ pub enum UpgradeCmds {
/// Subcommand for upgrading a `client`
#[options(help = "Upgrade an IBC client")]
Client(TxUpgradeClientCmd),

/// Subcommand for upgrading all `client`s that target specified chain
#[options(help = "Upgrade all IBC clients that target a specific chain")]
Clients(TxUpgradeClientsCmd),
//
// NOTE: This command is disabled until https://github.com/informalsystems/ibc-rs/issues/1229 is fixed.
//
// /// Subcommand for upgrading all `client`s that target specified chain
// #[options(help = "Upgrade all IBC clients that target a specific chain")]
// Clients(TxUpgradeClientsCmd),
}

0 comments on commit c145b25

Please sign in to comment.