Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to lint Dockerfile using dockerfilelint #974

Merged
merged 1 commit into from
May 20, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented May 20, 2024

This fixes #969. Since dockerfilelint is not really maintained and hadolint is a much better option (but cannot be used right now), we run it using npx on GHA directly without adding it as a devDependency to package.json.

@make-github-pseudonymous-again make-github-pseudonymous-again added ci This issue is about continuous integration dx This is about developer experience research This needs some research. labels May 20, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again changed the title Lint Dockerfile using dockerfilelint Add workflow to lint Dockerfile using dockerfilelint May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (6308ea8) to head (e5533de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   65.88%   65.86%   -0.03%     
==========================================
  Files         715      715              
  Lines        9893     9893              
  Branches     1346     1346              
==========================================
- Hits         6518     6516       -2     
- Misses       2917     2918       +1     
- Partials      458      459       +1     
Flag Coverage Δ
client 46.23% <ø> (-0.03%) ⬇️
server 61.87% <ø> (ø)
test 71.97% <ø> (ø)
test-app 53.70% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review May 20, 2024 19:28
Merged via the queue into main with commit 89998b8 May 20, 2024
31 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the ci-lint-docker-files-2 branch May 20, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This issue is about continuous integration dx This is about developer experience research This needs some research.
Projects
Development

Successfully merging this pull request may close these issues.

Lint Dockerfile
1 participant