Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fixed NPA-112 and NPA-114 #247

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

JchhatbarInfoblox
Copy link
Collaborator

  • fixed Re-execution of IPv4/v6 network playbook shows 'changed' status.
  • fixed configuring DHCP option using 'num' field for network container is failing.

- fixed configuring dhcp option using 'num' field for network container is failing.
Copy link
Collaborator

@JkhatriInfobox JkhatriInfobox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Note: Adds limitation to the usage of options to use different key i.e. num and name

@JkhatriInfobox
Copy link
Collaborator

Coverage report issue was fixed in PR #246. Hence ignoring the once failure check.

@JkhatriInfobox JkhatriInfobox merged commit 4189c09 into infobloxopen:develop Aug 16, 2024
24 of 25 checks passed
JkhatriInfobox pushed a commit that referenced this pull request Sep 3, 2024
…us. (#247)

- fixed configuring dhcp option using 'num' field for network container is failing.
JkhatriInfobox added a commit that referenced this pull request Sep 11, 2024
* [FIX] added check for list element match. (#239)

* [FIX] NPA-73, Re-execution showing change for each execution. (#240)

* [FIX] NPA-77, Network container update operation. (#241)

* - added network_view in get object search. (#242)

* Ansible lint fix (#238)

* Rebase from develop branch

* anisible-lit fixes after rebase to develop branch.

* [FIX] Ansible lint
- changelog.yaml
- nios_network_idempotence.yml

* [FIX] CI job for ansible installation

* [NPA-83] Fixed DHCP options for IPv4/v6 network container. (#243)

* [NPA-83] Fixed dhcp options for IPv4/v6 network container.

* - Added dhcp options supports for ipv4 and ipv6 network container. (#245)

* - fixed Re-execution of IPv4/v6 network playbook shows 'changed' status. (#247)

- fixed configuring dhcp option using 'num' field for network container is failing.

* - [NPA-113] Unable to remove dhcp options from DHCP Range using ansible. (#248)

* [ADD]Integration and Unit test cases for extensible attribute. (#246)

* [ADD]Integration and Unit test cases for extensible attribute.

* [FIX] Sanity Error for Unit testcase

* [FIX] Coverage module version upgrade to v7.6.1 for devel branch with python3.12

* [FIX] Sanity Testt for extensible_attribute test.

* [IMP] Updated nios-test-container version from 4.0.0 to 5.0.0

* - [NPA-125] unable to configure dhcp options with combination of 'num' and 'name' field. (#250)

* [FIX] added check for list element match. (#239)

* [FIX] NPA-73, Re-execution showing change for each execution. (#240)

* [FIX] NPA-77, Network container update operation. (#241)

* - added network_view in get object search. (#242)

* Ansible lint fix (#238)

* Rebase from develop branch

* anisible-lit fixes after rebase to develop branch.

* [FIX] Ansible lint
- changelog.yaml
- nios_network_idempotence.yml

* [FIX] CI job for ansible installation

* [NPA-83] Fixed DHCP options for IPv4/v6 network container. (#243)

* [NPA-83] Fixed dhcp options for IPv4/v6 network container.

* - Added dhcp options supports for ipv4 and ipv6 network container. (#245)

* - fixed Re-execution of IPv4/v6 network playbook shows 'changed' status. (#247)

- fixed configuring dhcp option using 'num' field for network container is failing.

* - [NPA-113] Unable to remove dhcp options from DHCP Range using ansible. (#248)

* [ADD]Integration and Unit test cases for extensible attribute. (#246)

* [ADD]Integration and Unit test cases for extensible attribute.

* [FIX] Sanity Error for Unit testcase

* [FIX] Coverage module version upgrade to v7.6.1 for devel branch with python3.12

* [FIX] Sanity Testt for extensible_attribute test.

* [IMP] Updated nios-test-container version from 4.0.0 to 5.0.0

* - [NPA-125] unable to configure dhcp options with combination of 'num' and 'name' field. (#250)

* [IMP] Updated depricated artifact v1 to v4

---------

Co-authored-by: Jaykumar Chhatbar <45447272+JchhatbarInfoblox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants