Enforce selecting ref from network_obj based on network view

[philipsd6]

Since there can be multiple network views containing the same networks, we need to ensure that the correct network in the network_obj list is picked based on a network view name, instead of simply taking it from the first one in the list. The 'default' view is used by default.

Fixes: #156

[ranjishmp]

Hi @hemanthKa677, please review this PR

[hemanthKa677]

Hi @philipsd6 , Can you please provide us information on how you are debugging this both files? As there are no playbooks to test these features.

[philipsd6]

Well, I didn't update any test fixtures because there were no test fixtures in the first place for the lookup plugins. I'll try to take a look to see how we can add test fixtures for lookup plugins and add that. However, this is a small easily reviewed change where the only new implication is that the lookup could fail if an Infoblox system doesn't have a 'default' network view and the user doesn't specify the desired view.

But fwiw, I tested the code directly in our Infoblox test sytem - replicating the error that occurs when the 'default' view is not the first one in the list, and then having it run correctly with the code I added to the plugin.

[hemanthKa677]

I have tested changes locally. Please make these changes, add the network_view attribute in both examples of lookup files. Please write network instead net in the both files, for better understanding the code. Beside this everything looks good.

[philipsd6]

@hemanthKa677 Done as requested.

[hemanthKa677]

Looks good to me

[hemanthKa677]

Looks good to me

[hemanthKa677]

@philipsd6 Please find that CI build checks are failing with some unit and sanity tests, Can you please fix those? In the sanity test devel, it is failing not only with pep8 linting issue, but also because of preferred_primaries in the nios_nsgroup.py it is given default as empty list, but it is actually None.