fix(json_v2): remove dead code #9908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
approved these changes
Oct 12, 2021
|
@sspaink approved, but I merged your other MPs which are causing conflicts. Can you resolve and then ping me for a quick review? Thanks! |
added 2 commits
October 13, 2021 10:21
586a8b5 to
067abc6
Compare
|
📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
powersj
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a few lines of code in the json_v2 parser that don't seem to be getting used, tests still pass and weren't changed. The function
existsInpathResultseven had a parameter it wasn't using, surprised the linter didn't catch this. The parser could use more refactoring, this is a start in cleaning it up.