Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update toml tag to match sample config / readme #9848

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

helenosheaa
Copy link
Member

resolves #9829

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 1, 2021
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2021
@srebhan srebhan self-assigned this Oct 4, 2021
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is if folks are using "headers" already, they will have breakage in the next version. Instead, should the documentation get updated to show "headers" as the correct value?

@helenosheaa
Copy link
Member Author

@powersj yeah I was sort of torn between which is less disruptive. The http_headers key is what was in the readme and in the sample config so anyone who figured out they needed to use headers instead would have had to go looking in the plugin code for it.

Considering the plugin has only been around since 1.18 I thought making it match the spec would be ok. However happy to change the readme instead, thoughts?

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like merging this as-is makes sense, as we have not received an issue about this till now.

@helenosheaa helenosheaa merged commit 021dedb into master Oct 4, 2021
@helenosheaa helenosheaa deleted the fix-loki-toml branch October 4, 2021 14:05
reimda pushed a commit that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small nuance
4 participants