-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update toml tag to match sample config / readme #9848
Conversation
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is if folks are using "headers" already, they will have breakage in the next version. Instead, should the documentation get updated to show "headers" as the correct value?
@powersj yeah I was sort of torn between which is less disruptive. The Considering the plugin has only been around since 1.18 I thought making it match the spec would be ok. However happy to change the readme instead, thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like merging this as-is makes sense, as we have not received an issue about this till now.
(cherry picked from commit 021dedb)
resolves #9829