fix: memory leak in influx parser #9787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time the code reached the end of the previous buffered read data, and had an incomplete metric, it would do a read to re-fill the buffer, and then because the buffer was now full, would mistakenly double the buffer's size.
8f9451b to
666dd32
Compare
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
powersj
approved these changes
Sep 22, 2021
|
Hi Patrick, thanks for tracking down this memory leak. There is an open PR to switch to a newer line protocol parser that is shared with other InfluxData projects (#9685). We're not quite ready to merge it because there was a report of a panic a couple days ago. This leak fix may be useful if the panic or something else prevents us from switching parsers, but I wanted to make sure you knew the long term plans for the parser. I'd be interested in your opinion on the new parser if you have time to take a look at it. |
reimda
pushed a commit
that referenced
this pull request
Oct 7, 2021
(cherry picked from commit 128ed88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time the code reached the end of the previous buffered read data, and had an incomplete metric, it would do a read to re-fill the buffer, and then because the buffer was now full, would mistakenly double the buffer's size.
It's obvious from the code that the intent was to grow the buffer if it did not contain a complete metric and the buffer was full. Rearranging the code does this, and fixes the problem.
I classified this as a memory leak, as while the memory isn't lost, usage grows uncontrollably and is never reclaimed.
Required for all PRs:
resolves #