Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mock input plugin #9782

Merged
merged 4 commits into from
Dec 23, 2021
Merged

feat: add mock input plugin #9782

merged 4 commits into from
Dec 23, 2021

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 20, 2021 •
edited
Loading

Will generate random data based on a variety of algorithms. Options
include random, stepwise, sine-wave, and stock-like data values.

Resolves: #9749

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 20, 2021
@powersj powersj mentioned this pull request Sep 20, 2021
Closed
@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

srebhan
srebhan reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powersj thanks for this plugin. It's really missing for testing! There are some comments in the code, please have a look.

@srebhan srebhan self-assigned this Dec 8, 2021
@powersj
feat: add mock input plugin
6dc7a10 
Will generate random data based on a variety of algorithms. Options
include random, stepwise, sine-wave, and stock-like data values.

Resolves: influxdata#9749
@powersj
Updates from review
2a42782
@powersj
Copy link
Contributor Author

powersj commented Dec 22, 2021

@powersj thanks for this plugin. It's really missing for testing! There are some comments in the code, please have a look.

Thank you for the review! I totally missed the email update, but I believe I have now taken care of everything.

srebhan
srebhan reviewed Dec 22, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem @powersj. There are a few more things, most importantly the JSON vs. TOML tags. Can you please explain why to do it this way?

@telegraf-tiger
Copy link
Contributor

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb s390x.rpm linux_amd64.tar.gz
mipsel.deb x86_64.rpm linux_arm64.tar.gz
ppc64el.deb linux_armel.tar.gz
s390x.deb linux_armhf.tar.gz
linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for finishing this off! Have nice Christmas holidays and a good start into the new year! See you in 2022.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 22, 2021
@powersj
Copy link
Contributor Author

powersj commented Dec 22, 2021

Looks good to me. Thanks for finishing this off! Have nice Christmas holidays and a good start into the new year! See you in 2022.

Thank you! You too!

@powersj powersj merged commit 2220fa2 into influxdata:master Dec 23, 2021
@powersj powersj deleted the input/testdata branch December 23, 2021 20:35
powersj added a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@powersj
feat: add mock input plugin (influxdata#9782)
2b4d4f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock data input plugin
3 participants
@powersj @MyaLongmire @srebhan