Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add count of bonded slaves (for easier alerting) #9762

Merged
merged 3 commits into from
Sep 15, 2021
Merged

feat: add count of bonded slaves (for easier alerting) #9762

merged 3 commits into from
Sep 15, 2021

Conversation

johnseekins
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

Collecting the count of slaves to a network bond makes alerting on downed slaves/etc. much easier.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 15, 2021
@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

sspaink
sspaink approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 15, 2021
@MyaLongmire MyaLongmire merged commit 0e9391d into influxdata:master Sep 15, 2021
reimda pushed a commit that referenced this pull request Sep 17, 2021
@johnseekins @reimda
feat: add count of bonded slaves (for easier alerting) (#9762)
87564b8 
(cherry picked from commit 0e9391d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspaink sspaink sspaink approved these changes

@MyaLongmire MyaLongmire MyaLongmire approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnseekins @sspaink @MyaLongmire