fix: Add error message logging to outputs.http #9727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run a multitenant system with 1000s of users and some of them use Telegraf to push to us. The error logs they see look like this: ``` 2021-09-06T06:07:34Z E! [agent] Error writing to outputs.http: when writing to [XXX] received status code: 400 2021-09-06T06:07:34Z D! [outputs.http] Buffer fullness: 2410 / 200000 metrics 2021-09-06T06:07:34Z E! [agent] Error writing to outputs.http: when writing to [XXX] received status code: 400 2021-09-06T06:07:44Z D! [outputs.http] Buffer fullness: 2415 / 200000 metrics 2021-09-06T06:07:44Z E! [agent] Error writing to outputs.http: when writing to [XXXX] received status code: 400 ``` Our upstream returns actionable messages that make the issue pretty clear to our users, but those using Telegraf cannot see those messages. I propose that users should be able to see the error message returned from upstream. We're seeing more and more of our users adopting Telegraf and its an awesome project! This is not the first time our users contacted regarding this issue and I think this enhancement will be useful to wider community as well! This particular piece of code has been inspired by how Prometheus remote write does the error logging. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
sspaink
approved these changes
Sep 13, 2021
|
Thanks for the review @sspaink! Is there anything else I need to do to get this merged? |
reimda
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 357959f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run a multitenant system with 1000s of users and some of them use
Telegraf to push to us. The error logs they see look like this:
Our upstream returns actionable messages that make the issue pretty
clear to our users, but those using Telegraf cannot see those messages.
I propose that users should be able to see the error message returned
from upstream.
We're seeing more and more of our users adopting Telegraf and its an
awesome project! This is not the first time our users contacted
regarding this issue and I think this enhancement will be useful to
wider community as well!
This particular piece of code has been inspired by how Prometheus remote
write does the error logging.
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com
Required for all PRs:
resolves #