Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to disable prepared statements for PostgreSQL #9710

Merged

Conversation

akrantz01
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

resolves #9630

This adds an option for disabling the use of prepared statements in the postgresql and postgresql_extensible inputs. It also prevents changing the IsPgBouncer flag from the configuration which was previously possible.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 1, 2021
@srebhan
Copy link
Member

srebhan commented Dec 8, 2021

@akrantz01 any update on this PR?

@srebhan srebhan self-assigned this Dec 8, 2021
@akrantz01
Copy link
Contributor Author

akrantz01 commented Dec 13, 2021

@srebhan I think it should be ready to be merged once CI passes.

@akrantz01 akrantz01 force-pushed the 9630-optional-prepared-statements branch from c7c8a6a to effa975 Compare December 13, 2021 18:09
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akrantz01 thanks for the rebase, but I think you missed some of @sspaink 's comments.

@akrantz01
Copy link
Contributor Author

Whoops, I must've thought I had already addressed those. I think it should now actually be ready.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @akrantz01, thanks for the update. Found three very minor things but I guess afterwards we are good to go...

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@srebhan
Copy link
Member

srebhan commented Dec 21, 2021

@akrantz01 can you please make fmt? :-)

@telegraf-tiger
Copy link
Contributor

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 21, 2021
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @akrantz01 for bringing this PR over the finish-line.

@powersj powersj merged commit e6cd83f into influxdata:master Dec 22, 2021
powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/postgresql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres input plugin should provide an option to disable prepared statements (PgBouncer support)
4 participants