-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to disable prepared statements for PostgreSQL #9710
feat: add option to disable prepared statements for PostgreSQL #9710
Conversation
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
@akrantz01 any update on this PR? |
@srebhan I think it should be ready to be merged once CI passes. |
c7c8a6a
to
effa975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akrantz01 thanks for the rebase, but I think you missed some of @sspaink 's comments.
Whoops, I must've thought I had already addressed those. I think it should now actually be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @akrantz01, thanks for the update. Found three very minor things but I guess afterwards we are good to go...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@akrantz01 can you please |
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @akrantz01 for bringing this PR over the finish-line.
Required for all PRs:
resolves #9630
This adds an option for disabling the use of prepared statements in the
postgresql
andpostgresql_extensible
inputs. It also prevents changing theIsPgBouncer
flag from the configuration which was previously possible.