Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongodb): change command based on server version #9674

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

akrantz01
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

resolves #9622

Fixes a bug where gathering the pool statistics for a MongoDB server running version 5.0.0 or greater would fail since the command was renamed from shardConnPoolStats to connPoolStats. This was fixed by changing command run based on the version of the server reported from serverStatus.

@akrantz01 akrantz01 added fix pr to fix corresponding bug area/mongodb labels Aug 24, 2021
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Maybe the README.md should also be updated to show what versions are supported?

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 25, 2021
@akrantz01
Copy link
Contributor Author

Oh yea, that'd be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mongodb fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with gather in MongoDB 5.0
2 participants