fix: Couchbase insecure certificate validation #9458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @akrantz01 thanks for looking into this! TBH, I'm not sure this is the right approach, as it uses an "insecure by default" approach without allowing the user to enforce strict security rules. So I think you should either replicate the client behavior (only insecure if no certificate is provided) OR (and this is my preference) you allow the user to set |
reimda
suggested changes
Jul 6, 2021
ssoroka
suggested changes
Aug 5, 2021
7f6d502 to
94349b8
Compare
sspaink
approved these changes
Aug 24, 2021
reimda
reviewed
Sep 9, 2021
srebhan
approved these changes
Sep 23, 2021
reimda
approved these changes
Sep 23, 2021
|
Hey @akrantz01 could you resolve the conflicts and I'll merge this? Thanks again! |
5a9691e to
63e4479
Compare
|
I want to click merge, but lint is failing in couchbase_test.go. Tried editing it in GitHub, but it doesn't show as an issue. Pulling down the MP does show the issue, so typing |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
|
@akrantz01 thank you for bringing this one home! |
reimda
pushed a commit
that referenced
this pull request
Oct 6, 2021
(cherry picked from commit 872b29b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9454
Fixes a bug where the
couchbaseplugin would fail to retrieve bucket stats due to a self-signed certificate. Prior, only the bucket stats would fail because the couchbase library skips certificate verification by default unless a keypair and optional root certificate are provided.