Add new output plugin for Azure Data Explorer(ADX) #9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
suggested changes
Jul 6, 2021
| .create-or-alter table ['table-name'] ingestion json mapping 'table-name_mapping' '[{"column":"fields", "Properties":{"Path":"$[\'fields\']"}},{"column":"name", "Properties":{"Path":"$[\'name\']"}},{"column":"tags", "Properties":{"Path":"$[\'tags\']"}},{"column":"timestamp", "Properties":{"Path":"$[\'timestamp\']"}}]' | ||
| ``` | ||
|
|
||
| **Note**: This plugin will automatically create Azure Data Explorer tables and corresponding table mapping as per the above mentioned commands. Since the `Metric` object is a complex type, the only output format supported is JSON, so make sure to set the `data_format` configuration in `telegraf.conf` to `json`. |
There was a problem hiding this comment.
Since you're creating the serializer yourself manually, you don't need to tell users to set the serializer to json.
| expectedWriteError string | ||
| }{ | ||
| { | ||
| name: "Valid metric", |
There was a problem hiding this comment.
looks like you could add a test that verifies that fields and tags and timestamps are serialized properly.
rename namespace to tableName
Case Insensitive MetricsGrouping
|
As suggested by @sjwang90, adding new feature in plugin in the same PR. This feature allows to add all the metrics into a single Azure Data Explorer(ADX) table rather than creating separate ADX table for each metric. This is just to provide flexibility for the end users in case they don't want to use joins across different ADX tables that feed their monitoring dashboards. |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Fix lint issues in main for final PR
ssoroka
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
It resolves #9230
It is a new output plugin for Azure Data Explorer, its been tested with SQL Server input plugin but it can work with any input plugin of Telegraf.