Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dynatrace output #9363

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Update dynatrace output #9363

merged 9 commits into from
Jun 15, 2021

Conversation

dyladan
Copy link
Contributor

@dyladan dyladan commented Jun 14, 2021 •
edited
Loading

  • export timestamps
  • Add default dimensions feature

Required for all PRs:

  • Updated associated README.md.
    • Seems the readme already mentioned the associated default_dimensions feature for some reason
  • Wrote appropriate unit tests.

dyladan added 2 commits June 14, 2021 12:10
@dyladan
Update dynatrace output
79fbdf6 
- export timestamps
- enrich dimensions with OneAgent data
- Add default dimensions feature
@dyladan
Update documentation
d4fd3ae
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 14, 2021
@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

srebhan
srebhan approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @dyladan! Looks good to me without any comments. :-)

@srebhan srebhan self-assigned this Jun 14, 2021
@srebhan srebhan added plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jun 14, 2021
@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@srebhan
Copy link
Member

srebhan commented Jun 15, 2021

@dyladan may I ask why you remove those dimensions? Is there some problem?

@srebhan srebhan closed this Jun 15, 2021
@srebhan srebhan reopened this Jun 15, 2021
@srebhan
Copy link
Member

srebhan commented Jun 15, 2021

Sorry wrong button. :-S

@dyladan
Copy link
Contributor Author

dyladan commented Jun 15, 2021

@dyladan may I ask why you remove those dimensions? Is there some problem?

No problem. Since this doesn't run in-process with the monitored application, we are having internal discussions as to whether or not the oneagent data enrichment makes sense in this context. I removed the commented code line to reduce confusion.

@dyladan
Copy link
Contributor Author

dyladan commented Jun 15, 2021

It shouldn't block the PR since it can always be added later

@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

arminru
arminru approved these changes Jun 15, 2021
View reviewed changes
@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

arminru
arminru approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

ssoroka
ssoroka approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about dt.metrics.source being a static dimension for all metrics, but it's not a blocker for me.

@ssoroka ssoroka merged commit 769f582 into influxdata:master Jun 15, 2021
@dyladan dyladan deleted the update-dt-exporter branch June 15, 2021 21:13
reimda pushed a commit that referenced this pull request Jul 28, 2021
@dyladan @reimda
Update dynatrace output (#9363)
baf84f0 
- export timestamps
- enrich dimensions with OneAgent data
- Add default dimensions feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@ssoroka ssoroka ssoroka approved these changes

@arminru arminru arminru approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyladan @srebhan @ssoroka @arminru