Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature powermode smartctl #9306

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Feature powermode smartctl #9306

merged 7 commits into from
Jun 10, 2021

Conversation

MyaLongmire
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md. - just added an attribute so no change to the readme necessary
  • Wrote appropriate unit tests. - the new power attribute is covered by the TestGatherAttributes test

resolves #7328

added regexs to find Power mode and Device is in STANDBY
used an if statement to check if Power mode is found if it is found then set the power attribute
if it is not found look for Device is in STANDBY (this happens when nocheck is set to standby and the device is in standby) and set the power attribute
if neither is found (like with NVMe drives) skip over the power attribute

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 26, 2021
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sspaink sspaink merged commit f6a9d10 into master Jun 10, 2021
@sspaink sspaink deleted the feature-powermode-smartctl branch June 10, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HDD power mode status to SMART plugin
4 participants